vello_common: Use binary search to determine the start index in clipping#1691
Open
LaurenzV wants to merge 1 commit into
Open
vello_common: Use binary search to determine the start index in clipping#1691LaurenzV wants to merge 1 commit into
LaurenzV wants to merge 1 commit into
Conversation
LaurenzV
force-pushed
the
laurenz/clip_first
branch
from
b5f3623 to
c5a4296
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1690. I think this should mostly be self-explanatory with the comments. This brings the clipping time in that particular example from 4.4% to 2.6%: