Remove wgpu feature. Add wgpu_27 and wgpu_28 features.#1330
Closed
nicoburns wants to merge 3 commits intolinebender:mainfrom
Closed
Remove wgpu feature. Add wgpu_27 and wgpu_28 features.#1330nicoburns wants to merge 3 commits intolinebender:mainfrom
wgpu feature. Add wgpu_27 and wgpu_28 features.#1330nicoburns wants to merge 3 commits intolinebender:mainfrom
Conversation
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Collaborator
|
I'd like to see this happen and get a release out! Do you want to update this or should someone else take it up? cc: @xStrom @PoignardAzur |
Member
|
I'm not sure if it's worth actually supporting multiple wgpu versions. However, just as a technical note, the features should also work if both are selected. Probably the highest version should win then. So in this PR if both |
PoignardAzur
reviewed
Mar 4, 2026
Collaborator
PoignardAzur
left a comment
There was a problem hiding this comment.
I don't have a strong opinion on this, but it seems like a lot of churn.
Comment on lines
+30
to
+31
| // debug_assert_eq!(info.push_constant_items.len(), 0, "unimplemented"); | ||
| debug_assert_eq!(info.immediates_items.len(), 0, "unimplemented"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Allow the same version of Vello to compile with multiple versions of WGPU (current v27 and v28):
Prior Art
The
i-slint-corecrate has similar feature flags for WGPU versions (https://docs.rs/crate/i-slint-core/latest/features)Changes made
wgpuandnagafeature flags in thevello,vello_hybrid,vello_shadersandvello_sparse_shaderscrates withwgpu_27,wgpu_28(andnaga_27,naga_28) feature flags.wgpu_28 as wgpuin the crate rootswgpu-profilerandhot-reloaddebug features are currently configured to only work with the latest WGPU version.Todo
wgpu-profileronce Update wgpu dependency to version 28 Wumpf/wgpu-profiler#103 lands