Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I began drafting out a basic 64-bit integer support.
A few tests has been added to assist development a few more are likely to be added.
I didn't check-in the generated code from
cargo run -p fearless_simd_genyet since i think its easier to review w/o.Whats next:
This is tested with
cargo test -p fearless_simd_testsandRUSTFLAGS=-Ctarget-feature=+simd128 wasm-pack test --headless --firefox(note: i couldn't get --chrome to work on my)Both passes with the additional tests after generated code has been updated.