Make SIMD stores safe#238
Merged
Merged
Conversation
LaurenzV
approved these changes
May 29, 2026
Collaborator
LaurenzV
left a comment
There was a problem hiding this comment.
I haven't verified the memcpy claim but gonna trust you on this! The code makes sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors #232 but for stores
Performance is unchanged or potentially improved: the old codegen emitted
ptr::copy_nonoverlappingwhich lowered into amemcpyin the LLVM IR, while this approach lowers into an unaligned store directly, which is the same thing as platform-specific SIMD instructions lower to. (Yes, platform-specific SIMD intrinsics lower into a generic op!)