This repository was archived by the owner on Dec 1, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
add infer_nesting to reduce #90
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Click here to view all benchmarks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 95.76% 95.78% +0.01%
==========================================
Files 9 9
Lines 260 261 +1
==========================================
+ Hits 249 250 +1
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Took a step towards #73 here by adopting dask's native meta inference. Dask tries the function on some dummy data and sets the meta accordingly, note that this will never resolve a correct dtype for nesteddtypes and often will not for even normal dtypes. |
hombit
approved these changes
Mar 17, 2025
Collaborator
hombit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's go with it!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #89.
The usability of this on the nested-dask side is hit pretty hard by meta assignment, as the user needs to build their own nesteddtypes appropriately, like this:
You can get away from this by just making these object columns, technically, but the downstream consequences of not keeping these dtypes correct will likely be pretty obstructive. This means that unless we find a way to soften the meta requirements (#73), a user would likely want to not use the infer_nesting feature and instead use a pack_lists style call after reduce.
A potential choice to make here could even be to specifically not support nesting inference until #73, but given that the motivator for this feature comes from LSDB it would be unfortunate to not have it be available in dask.