[CI] Pack necessary .dll in resulting Windows artifact #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d macOS (OpenCL) Also, it runs `runtests` and publishes build artifacts fix lightvector#1124
It allows handling field sizes for accurately that are actual for Dots game because its default size is not a square.
…toring them in `State`
It makes them consistent to current rules (Go or Go Game) and allows getting rid of unnecessary allocations
Introduce `whiteScoreIfGroundingAlive`, `isGroundingWinsGame` Remove `getAreaNow` because it's unused
…ayMoveRecordedDots` It works much faster than `playMoveRecordedDots` although it leads to some code duplication Introduce some other minor Dots field optimizations
Fill app info (katago) during writing SGF
… game always can be finished by grounding And it's unclear how to calculate the resulting score if the game is not finished by grounding, but the winner is already known
…ing placement moves
…pos_len` (not finished)
…lculateCapturesAndBases` Refine `Rules` constructor for Go and Dots
Because the hash depends on MAX_SIZE, and it's inconvenient on the experimental stage because the value might vary quite often
It significantly decreases game duration because typically it doesn't make sense to play until the very end in case of zero komi and when all dots are grounded.
Rename `numLegalMoves` to `numLegalMovesIfSuiAllowed` because it's an expensive operation to calculate the number if sui is on
Commands for field setup (size, rules), handicap placement fix #4 Dottify the engine: * Use numbers instead of latin numbers in field output * Player1, Player2 instead of Black and White * Tidy up default for Dots game (39*32 default size)
However, it should be restored later when NN is unified with Go models (22 for spatial and 19 for global)
Run Global utils tests
Fix `set_position` to recognize start position Fix start pos recognizer Remove `START_POS_CUSTOM` because now all unrecognized moves are accessible via passed `remainingMoves`
It's temporary because the changes are actually dirty
The main reason is to support it in GTP protocol Don't generate the resignation move in utils because normally it makes little sense
Dottify `final_score`
It's needed for the next commit. This reverts commit 29e8e69.
…odel version 7 (22 and 19) Embed info about Dots Game into model fix #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.