Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: governance and workflow alignment audit #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
chore: governance and workflow alignment audit #752
Changes from all commits
8113cfe43578fe7ff7a16b790f28fe518fdd3a6a063492367706ad518f3d286baa72e00083c3fFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the repository's general rules, migration maps and notes should be documented in a central
/docs/MIGRATION.mdfile to ensure contributors can follow migration rules mentioned in README files across the repository. Please move or reference these migration rules in/docs/MIGRATION.md.References
/docs/MIGRATION.mdfile to ensure contributors can follow migration rules mentioned in README files across the repository.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking only for the existence of the file using
fs.existsSyncis a very weak test that does not verify if the module can be successfully required or if it has any syntax errors. Please require the module and verify its baseline exports/behavior, similar toproject-meta-sync.agent.test.js.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.