Skip to content

LCORE- Update make target to only format src and test directories#1728

Open
samdoran wants to merge 1 commit into
lightspeed-core:mainfrom
samdoran:lint-src-tests-only
Open

LCORE- Update make target to only format src and test directories#1728
samdoran wants to merge 1 commit into
lightspeed-core:mainfrom
samdoran:lint-src-tests-only

Conversation

@samdoran
Copy link
Copy Markdown
Contributor

Description

Trying to format the examples directory results in a failure from black which prevents the ruff check from running.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Generated by: Me

Related Tickets & Documents

None

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

Run make format. Without this change:

uv run black --line-length 88 .
error: cannot format /Users/sdoran/Developer/lightspeed-stack/docs/demos/lcore/weak_points_for_ai/ex1.py: Cannot parse for target version Python 3.13: 3:0:     for key, value in entry.items():
reformatted /Users/sdoran/Developer/lightspeed-stack/docs/demos/lcore/weak_points_for_ai/ex9.py
error: cannot format /Users/sdoran/Developer/lightspeed-stack/docs/demos/lcore/weak_points_for_ai/ex5.py: Cannot parse for target version Python 3.13: 146:8:         )
reformatted /Users/sdoran/Developer/lightspeed-stack/docs/demos/lcore/weak_points_for_ai/ex3.py
reformatted /Users/sdoran/Developer/lightspeed-stack/docs/demos/lcore/weak_points_for_ai/exA.py
reformatted /Users/sdoran/Developer/lightspeed-stack/docs/demos/lcore/weak_points_for_ai/exB.py

Oh no! 💥 💔 💥
4 files reformatted, 401 files left unchanged, 2 files failed to reformat.
make: *** [format] Error 123

With this change:

> make format
uv run black --line-length 88 src tests
All done! ✨ 🍰 ✨
392 files left unchanged.
uv run ruff check src tests --fix
All checks passed!

Trying to format the examples directory results in a failure from black
which prevents the ruff check from running.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

Warning

Rate limit exceeded

@samdoran has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 38 minutes and 44 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fad0f780-d47f-4ab4-b1ab-1482aa4df268

📥 Commits

Reviewing files that changed from the base of the PR and between 22c9f02 and e6536aa.

📒 Files selected for processing (1)
  • Makefile
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@samdoran
Copy link
Copy Markdown
Contributor Author

If we want to run black on the whole project, I can add a configuration to exclude the weak_points_for_ai directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant