Add region and currencies list to grid customers#320
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-openapi studio · code · diff
⏳ grid-python studio · code · diff
⏳ These are partial results; builds are still running. This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Greptile SummaryThis PR adds Confidence Score: 5/5Safe to merge; the only finding is a P2 documentation wording issue that does not affect API behaviour. All structural and semantic changes are correct. The openapi/components/schemas/customers/CustomerCreateRequest.yaml — minor
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/customers/Customer.yaml | Adds region (ISO 3166-1 alpha-2) and currencies (string array) fields to the Customer response schema |
| openapi/components/schemas/customers/CustomerCreateRequest.yaml | Adds region and currencies to create request; umaAddress description contains stale update-specific wording and a duplicate sentence |
| openapi/components/schemas/customers/CustomerUpdateRequest.yaml | Adds currencies to update request; correctly omits region since it is immutable after creation |
| openapi/paths/customers/customers.yaml | Adds region and currency query filter parameters; updates POST examples to include region/currencies |
| openapi/paths/customers/customers_{customerId}.yaml | Updates PATCH examples to include currencies for both individual and business customer updates |
| openapi/webhooks/customer-update.yaml | Updates all four webhook payload examples (KYC/KYB approved/rejected) to include region and currencies |
Sequence Diagram
sequenceDiagram
participant Client
participant GridAPI as Grid API
participant Webhook as Webhook Endpoint
Client->>GridAPI: POST /customers {region: "US", currencies: ["USD","USDC"]}
GridAPI-->>Client: 201 Customer {id, region: "US", currencies: ["USD","USDC"]}
Client->>GridAPI: GET /customers?region=US¤cy=USD
GridAPI-->>Client: 200 [{region: "US", currencies: ["USD","USDC"]}, ...]
GridAPI->>Webhook: POST {type: "CUSTOMER.KYC_APPROVED", data: {region: "US", currencies: ["USD","USDC"]}}
Webhook-->>GridAPI: 200 OK
Comments Outside Diff (1)
-
openapi/components/schemas/customers/CustomerCreateRequest.yaml, line 38-41 (link)Stale update context and duplicate sentence in
umaAddressdescriptionThe description includes "If provided during customer update, the UMA address will be updated to the provided value." — update-specific wording that doesn't belong in a Create request schema. The sentence "This is an optional identifier to route payments to the customer." is also repeated twice immediately after.
Prompt To Fix With AI
This is a comment left during a code review. Path: openapi/components/schemas/customers/CustomerCreateRequest.yaml Line: 38-41 Comment: **Stale update context and duplicate sentence in `umaAddress` description** The description includes "If provided during customer update, the UMA address will be updated to the provided value." — update-specific wording that doesn't belong in a Create request schema. The sentence "This is an optional identifier to route payments to the customer." is also repeated twice immediately after. How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
This is a comment left during a code review.
Path: openapi/components/schemas/customers/CustomerCreateRequest.yaml
Line: 38-41
Comment:
**Stale update context and duplicate sentence in `umaAddress` description**
The description includes "If provided during customer update, the UMA address will be updated to the provided value." — update-specific wording that doesn't belong in a Create request schema. The sentence "This is an optional identifier to route payments to the customer." is also repeated twice immediately after.
```suggestion
umaAddress:
type: string
description: >-
Optional UMA address identifier. If not provided during customer creation, one will be generated by the system.
This is an optional identifier to route payments to the customer.
example: $john.doe@uma.domain.com
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "Add region and currencies list to grid c..." | Re-trigger Greptile

No description provided.