Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Greptile SummaryThis PR adds PHP Bank Transfer and GBP Faster Payments tabs with curl examples and validation code, and introduces a new "Minimum required beneficiary fields" section covering individual beneficiaries by country.
Confidence Score: 4/5Safe to merge after fixing the misleading intro text or adding the missing business beneficiaries table One P1 finding remains: the section intro promises business beneficiary coverage that does not exist, actively misleading developers. The new PHP/GBP examples and validation code are correct and well-formed. mintlify/snippets/external-accounts.mdx — the Minimum required beneficiary fields section intro at line 599
|
| Filename | Overview |
|---|---|
| mintlify/snippets/external-accounts.mdx | Adds PHP/GBP tabs and a minimum-required-fields table for individual beneficiaries; intro text incorrectly promises business beneficiary coverage that is absent |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Developer creates external account] --> B{Currency / Region?}
B --> |USD| C[US_ACCOUNT]
B --> |MXN| D[CLABE]
B --> |BRL| E[PIX]
B --> |EUR| F[IBAN/SEPA]
B --> |PHP| G[PHP_ACCOUNT\n8-16 digit account number]
B --> |GBP| H[GBP_ACCOUNT\n6-digit sortCode + 8-digit accountNumber]
C & D & E & F & G & H --> I{Beneficiary type?}
I --> |INDIVIDUAL| J[fullName required\naddress required for USD/GBP/EUR]
I --> |BUSINESS| K[businessInfo.legalName required\nNo min-fields table in docs yet]
J & K --> L[Submit → PENDING]
L --> M[Compliance review]
M --> |Pass| N[ACTIVE]
M --> |Flag| O[UNDER_REVIEW / INACTIVE]
Prompt To Fix All With AI
This is a comment left during a code review.
Path: mintlify/snippets/external-accounts.mdx
Line: 599
Comment:
**Missing business beneficiaries table**
The intro text states it covers "individual *and* business beneficiaries by country," but only a `### Individual beneficiaries` subsection follows — there is no `### Business beneficiaries` table anywhere before `## Account status`. Developers building business account flows will be pointed here and find nothing.
Either add the missing `### Business beneficiaries` table, or narrow the intro to only reference individual beneficiaries:
```suggestion
The following table shows the minimum required fields for individual beneficiaries by country. All other fields are optional but recommended for faster compliance review.
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (4): Last reviewed commit: "feat: adding more docs about minimum req..." | Re-trigger Greptile
7227f24 to
8a1c61b
Compare
|
|
||
| | Country | Required Fields | Required Address Fields | | ||
| | --- | --- | --- | | ||
| | US (USD) | `beneficiaryType`, `fullName` | None (address optional) | |
There was a problem hiding this comment.
We will need line1, city, postal code, and country for US beneficiaries when adding an external account
8a1c61b to
e3ae89d
Compare
e3ae89d to
3b0055e
Compare
wuvictor-95
left a comment
There was a problem hiding this comment.
Looks fine to me for US, maybe others can check for other countries

No description provided.