Skip to content

feat: adding more docs about minimum required data for external accounts#312

Merged
pengying merged 1 commit intomainfrom
03-31-feat_adding_more_docs_about_minimum_required_data_for_external_accounts
Apr 7, 2026
Merged

feat: adding more docs about minimum required data for external accounts#312
pengying merged 1 commit intomainfrom
03-31-feat_adding_more_docs_about_minimum_required_data_for_external_accounts

Conversation

@pengying
Copy link
Copy Markdown
Contributor

@pengying pengying commented Apr 1, 2026

No description provided.

@mintlify
Copy link
Copy Markdown

mintlify bot commented Apr 1, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Grid 🟢 Ready View Preview Apr 1, 2026, 3:02 AM

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment Apr 7, 2026 7:02pm

Request Review

Copy link
Copy Markdown
Contributor Author

pengying commented Apr 1, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 1, 2026

Greptile Summary

This PR adds PHP Bank Transfer and GBP Faster Payments tabs with curl examples and validation code, and introduces a new "Minimum required beneficiary fields" section covering individual beneficiaries by country.

  • P1 — misleading intro text: The new section's intro (line 599) states it documents minimum required fields for "individual and business beneficiaries," but only a ### Individual beneficiaries table exists. There is no ### Business beneficiaries table, leaving developers building business account flows misled by the promised coverage.

Confidence Score: 4/5

Safe to merge after fixing the misleading intro text or adding the missing business beneficiaries table

One P1 finding remains: the section intro promises business beneficiary coverage that does not exist, actively misleading developers. The new PHP/GBP examples and validation code are correct and well-formed.

mintlify/snippets/external-accounts.mdx — the Minimum required beneficiary fields section intro at line 599

Important Files Changed

Filename Overview
mintlify/snippets/external-accounts.mdx Adds PHP/GBP tabs and a minimum-required-fields table for individual beneficiaries; intro text incorrectly promises business beneficiary coverage that is absent

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Developer creates external account] --> B{Currency / Region?}
    B --> |USD| C[US_ACCOUNT]
    B --> |MXN| D[CLABE]
    B --> |BRL| E[PIX]
    B --> |EUR| F[IBAN/SEPA]
    B --> |PHP| G[PHP_ACCOUNT\n8-16 digit account number]
    B --> |GBP| H[GBP_ACCOUNT\n6-digit sortCode + 8-digit accountNumber]
    C & D & E & F & G & H --> I{Beneficiary type?}
    I --> |INDIVIDUAL| J[fullName required\naddress required for USD/GBP/EUR]
    I --> |BUSINESS| K[businessInfo.legalName required\nNo min-fields table in docs yet]
    J & K --> L[Submit → PENDING]
    L --> M[Compliance review]
    M --> |Pass| N[ACTIVE]
    M --> |Flag| O[UNDER_REVIEW / INACTIVE]
Loading
Prompt To Fix All With AI
This is a comment left during a code review.
Path: mintlify/snippets/external-accounts.mdx
Line: 599

Comment:
**Missing business beneficiaries table**

The intro text states it covers "individual *and* business beneficiaries by country," but only a `### Individual beneficiaries` subsection follows — there is no `### Business beneficiaries` table anywhere before `## Account status`. Developers building business account flows will be pointed here and find nothing.

Either add the missing `### Business beneficiaries` table, or narrow the intro to only reference individual beneficiaries:

```suggestion
The following table shows the minimum required fields for individual beneficiaries by country. All other fields are optional but recommended for faster compliance review.
```

How can I resolve this? If you propose a fix, please make it concise.

Reviews (4): Last reviewed commit: "feat: adding more docs about minimum req..." | Re-trigger Greptile

@pengying pengying force-pushed the 03-31-feat_adding_more_docs_about_minimum_required_data_for_external_accounts branch from 7227f24 to 8a1c61b Compare April 7, 2026 18:45

| Country | Required Fields | Required Address Fields |
| --- | --- | --- |
| US (USD) | `beneficiaryType`, `fullName` | None (address optional) |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need line1, city, postal code, and country for US beneficiaries when adding an external account

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@pengying pengying force-pushed the 03-31-feat_adding_more_docs_about_minimum_required_data_for_external_accounts branch from 8a1c61b to e3ae89d Compare April 7, 2026 18:54
@pengying pengying force-pushed the 03-31-feat_adding_more_docs_about_minimum_required_data_for_external_accounts branch from e3ae89d to 3b0055e Compare April 7, 2026 19:01
Copy link
Copy Markdown
Contributor

@wuvictor-95 wuvictor-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me for US, maybe others can check for other countries

Copy link
Copy Markdown
Contributor Author

pengying commented Apr 7, 2026

Merge activity

  • Apr 7, 7:26 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 7, 7:26 PM UTC: @pengying merged this pull request with Graphite.

@pengying pengying merged commit 031ddbb into main Apr 7, 2026
9 checks passed
@pengying pengying deleted the 03-31-feat_adding_more_docs_about_minimum_required_data_for_external_accounts branch April 7, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants