Skip to content

Add source/destination type discriminators in examples#193

Merged
shreyav merged 1 commit intomainfrom
02-13-add_source_destination_type_discriminators_in_examples
Feb 13, 2026
Merged

Add source/destination type discriminators in examples#193
shreyav merged 1 commit intomainfrom
02-13-add_source_destination_type_discriminators_in_examples

Conversation

@shreyav
Copy link
Contributor

@shreyav shreyav commented Feb 13, 2026

No description provided.

Copy link
Contributor Author

shreyav commented Feb 13, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

✱ Stainless preview builds

This PR will update the grid SDKs with the following commit messages.

kotlin

feat: Add source/destination type discriminators in examples

openapi

feat(api): add sourceType/destinationType, remove counterpartyInformation from quotes

python

feat: Add source/destination type discriminators in examples

typescript

fix(types): remove counterpartyInformation field from quotes destination
grid-openapi studio · code

Your SDK built successfully.
generate ✅

grid-python studio · code

Your SDK built successfully.
generate ✅build ✅lint ✅test ✅

pip install https://pkg.stainless.com/s/grid-python/dfc60d8d85ca9fa477e879a51defa0761cf9bb1e/grid-0.0.1-py3-none-any.whl
grid-typescript studio · code

Your SDK built successfully.
generate ✅build ✅lint ✅test ✅

npm install https://pkg.stainless.com/s/grid-typescript/701e407c46d3d5101426afd436608a5db6d311da/dist.tar.gz
grid-kotlin studio · code

Your SDK built successfully.
generate ✅build ✅lint ✅test ✅


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-02-13 17:25:22 UTC

@shreyav shreyav force-pushed the 02-13-add_source_destination_type_discriminators_in_examples branch from 01811fb to 4b1dc8c Compare February 13, 2026 16:49
@shreyav shreyav marked this pull request as ready for review February 13, 2026 16:50
@shreyav shreyav requested a review from pengying February 13, 2026 16:50
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 13, 2026

Greptile Overview

Greptile Summary

This PR adds required discriminator fields (sourceType and destinationType) to all quote request examples throughout the documentation and OpenAPI specification. The changes ensure API examples align with the schema requirements where these discriminators are mandatory fields for the oneOf polymorphic types.

Key improvements:

  • Added sourceType discriminator to all source objects (values: ACCOUNT, REALTIME_FUNDING)
  • Added destinationType discriminator to all destination objects (values: ACCOUNT, UMA_ADDRESS, EXTERNAL_ACCOUNT_DETAILS)
  • Removed redundant currency fields from AccountDestination examples, as currency is determined by the account itself
  • Updated examples across 15 files including OpenAPI specs, MDX documentation, and reusable snippets

The changes are systematic, consistent, and technically correct according to the OpenAPI schema definitions.

Confidence Score: 5/5

  • This PR is safe to merge with no risks
  • All changes are documentation updates that correctly align examples with the required OpenAPI schema. The discriminator fields are mandatory according to the schema definitions, and their addition makes the examples accurate and functional. No logic changes, no code changes - purely documentation accuracy improvements.
  • No files require special attention

Important Files Changed

Filename Overview
openapi/paths/quotes/quotes.yaml Added required sourceType and destinationType discriminators to quote examples; correctly removed currency field from account-to-account destination
openapi.yaml Built OpenAPI spec correctly updated with discriminators from source changes
mintlify/openapi.yaml Mintlify copy of OpenAPI spec correctly updated with discriminators
mintlify/platform-overview/core-concepts/quote-system.mdx Comprehensive updates adding discriminators to all quote examples throughout the documentation
mintlify/snippets/sending/cross-currency.mdx Updated cross-currency examples with proper discriminators for ACCOUNT and REALTIME_FUNDING sources

Last reviewed commit: 4b1dc8c

@shreyav shreyav merged commit 7e2f818 into main Feb 13, 2026
8 of 9 checks passed
@shreyav shreyav deleted the 02-13-add_source_destination_type_discriminators_in_examples branch February 13, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants