Open
Conversation
Contributor
Greptile OverviewGreptile SummaryUpdated Stainless SDK configuration for multi-language publishing across TypeScript, Kotlin, and Python with proper package naming and repository references. Key Changes
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| .stainless/stainless.yml | Comprehensive SDK configuration update for multi-language publishing. Changes include organization branding, package naming, publishing setup (NPM/JSR/Maven/PyPI), webhook unwrapping, environment variable renaming (GRID_CLIENT_ID/GRID_CLIENT_SECRET/GRID_WEBHOOK_PUBKEY), OpenAPI transformation refactoring for discriminators, removal of error union config, and addition of npm release environment. |
Last reviewed commit: d3349f8
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| sandbox: | ||
| methods: | ||
| send_funds: post /sandbox/send | ||
| send_test_webhook: post /webhooks/test |
Contributor
There was a problem hiding this comment.
verify that generated SDK docs properly reflect this endpoint move from webhooks.send_test() to sandbox.send_test_webhook() to avoid breaking existing client code
Prompt To Fix With AI
This is a comment left during a code review.
Path: .stainless/stainless.yml
Line: 232:232
Comment:
verify that generated SDK docs properly reflect this endpoint move from `webhooks.send_test()` to `sandbox.send_test_webhook()` to avoid breaking existing client code
How can I resolve this? If you propose a fix, please make it concise.
pengying
force-pushed
the
02-12-feat_adding_webhook_config
branch
from
15b6eed to
d3349f8
Compare
Comment on lines
+410
to
+419
| - command: remove | ||
| reason: >- | ||
| Remove inline destinationType enums from transaction and quote | ||
| destination allOf variants to avoid conflicting types with their | ||
| base schemas which define destinationType via shared $ref enums | ||
| args: | ||
| unionPath: AllErrors | ||
| enumProperty: code | ||
| # ── customerType: IndividualCustomerFields / BusinessCustomerFields ── | ||
| target: | ||
| - "$.components.schemas.AccountTransactionDestination.allOf[0]" | ||
| - "$.components.schemas.UmaAddressTransactionDestination.allOf[0]" | ||
| keys: [ "$ref" ] |
Contributor
There was a problem hiding this comment.
Check that this transformation correctly removes the base schema reference. Removing $ref from allOf[0] is different from the pattern used in other transformations (which remove discriminator properties). Verify the generated SDK handles this correctly.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .stainless/stainless.yml
Line: 410:419
Comment:
Check that this transformation correctly removes the base schema reference. Removing `$ref` from `allOf[0]` is different from the pattern used in other transformations (which remove discriminator properties). Verify the generated SDK handles this correctly.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Updated Stainless configuration to prepare for SDK publishing across multiple languages with proper package naming and repository references.
What changed?
Changed organization name from "grid" to "Lightspark Grid"
Updated TypeScript configuration:
Updated Kotlin configuration:
Added Python configuration:
Simplified model references by commenting out unused schemas
Updated external account models with more consistent naming
Added webhook unwrapping functionality
Moved webhook test endpoint to sandbox resource
Updated environment variable names to use GRID_CLIENT_ID and GRID_CLIENT_SECRET
Fixed OpenAPI transformations to properly handle type discriminators
How to test?
Why make this change?
This change prepares the Grid API SDKs for proper publishing across multiple language ecosystems with consistent naming and structure. It improves the developer experience by providing better organized packages and fixing type discriminator issues that could cause compilation problems. The configuration now properly reflects the Lightspark branding and repository structure, making it ready for production use.