Closed
Conversation
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript Edit this comment to update them. They will appear in their respective SDK's changelogs.
|
⚠️ grid-openapi studio · code · diff
There was a regression in your SDK.
generate ⚠️(prev:generate ✅)New diagnostics (16 warning, 72 note)
⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`
⚠️ grid-kotlin studio · code · diff
There was a regression in your SDK.
generate ⚠️(prev:generate ✅) →build ✅→lint ✅→test ❗(prev:test ✅)New diagnostics (16 warning, 40 note)
⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`⚠️ Schema/DiscriminatedUnionVariantMissingProperty: Union variant doesn't define the property discriminator `accountType` which is required as the union schema defines `discriminator.propertyName`
❗ grid-python studio
Code was not generated because there was a fatal error.
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-02-12 19:26:57 UTC
Contributor
Greptile OverviewGreptile SummaryThis PR auto-syncs account schemas from VASP adapter field definitions. While it successfully adds new currency-specific account schemas (BRL, DKK, HKD, IDR, INR, MXN, MYR, THB, USD, VND) with corresponding beneficiary definitions, it introduces several critical issues: Critical Issues:
Schema Changes:
Impact: Confidence Score: 1/5
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml | Added new currency-specific account types to oneOf union, but created duplicate entries for existing accounts (e.g., both GbpAccountExternalAccountInfo.yaml and GbpExternalAccountInfo.yaml). Discriminator mapping also contains duplicates. |
| openapi/components/schemas/external_accounts/BaseExternalAccountInfo.yaml | No changes made, but discriminator mapping is now incomplete - missing new account types (BRL_ACCOUNT, DKK_ACCOUNT, etc.) added in ExternalAccountInfoOneOf.yaml. |
| openapi/components/schemas/external_accounts/ExternalAccountType.yaml | No changes made, but enum is now incomplete - missing new account type values (BRL_ACCOUNT, DKK_ACCOUNT, USD_ACCOUNT, etc.) referenced in discriminator mappings. |
| openapi/components/schemas/common/GbpAccountInfo.yaml | Removed accountType field, validation patterns, examples, and detailed descriptions. Changed to simplified generic descriptions. |
| openapi/components/schemas/common/SgdAccountInfo.yaml | Removed accountType, swiftCode field, validation patterns, and examples. Changed to simplified generic descriptions. |
| openapi.yaml | Bundled OpenAPI schema with all changes from modular files. Contains 1042 new lines reflecting the schema additions. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+14
to
+21
| - title: CAD Account | ||
| $ref: ./CadAccountExternalAccountInfo.yaml | ||
| - title: GBP Account | ||
| $ref: ./GbpAccountExternalAccountInfo.yaml | ||
| - title: PHP Account | ||
| $ref: ./PhpAccountExternalAccountInfo.yaml | ||
| - title: SGD Account | ||
| $ref: ./SgdAccountExternalAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
duplicate entries for CAD, GBP, PHP, and SGD accounts - both old naming convention (CadAccountExternalAccountInfo.yaml) and new naming convention (CadExternalAccountInfo.yaml) are listed in the oneOf array
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 14:21
Comment:
duplicate entries for CAD, GBP, PHP, and SGD accounts - both old naming convention (`CadAccountExternalAccountInfo.yaml`) and new naming convention (`CadExternalAccountInfo.yaml`) are listed in the oneOf array
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+36
to
+43
| - title: Cad Account | ||
| $ref: ./CadExternalAccountInfo.yaml | ||
| - title: Clabe Account | ||
| $ref: ./ClabeExternalAccountInfo.yaml | ||
| - title: Dkk Account | ||
| $ref: ./DkkExternalAccountInfo.yaml | ||
| - title: Gbp Account | ||
| $ref: ./GbpExternalAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
duplicate entries - CAD (line 15 and 37), CLABE (line 5 and 38), GBP (line 17 and 42), IBAN (line 9 and 46), NGN (line 13 and 56), PHP (line 19 and 58), PIX (line 7 and 60), SGD (line 21 and 62), UPI (line 11 and 66), US (line 3 and 68) all appear twice
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 36:43
Comment:
duplicate entries - CAD (line 15 and 37), CLABE (line 5 and 38), GBP (line 17 and 42), IBAN (line 9 and 46), NGN (line 13 and 56), PHP (line 19 and 58), PIX (line 7 and 60), SGD (line 21 and 62), UPI (line 11 and 66), US (line 3 and 68) all appear twice
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+93
to
+107
| BRL_ACCOUNT: ./BrlExternalAccountInfo.yaml | ||
| CLABE_ACCOUNT: ./ClabeExternalAccountInfo.yaml | ||
| DKK_ACCOUNT: ./DkkExternalAccountInfo.yaml | ||
| HKD_ACCOUNT: ./HkdExternalAccountInfo.yaml | ||
| IBAN_ACCOUNT: ./IbanExternalAccountInfo.yaml | ||
| IDR_ACCOUNT: ./IdrExternalAccountInfo.yaml | ||
| INR_ACCOUNT: ./InrExternalAccountInfo.yaml | ||
| LIGHTNING_ACCOUNT: ./LightningExternalAccountInfo.yaml | ||
| MXN_ACCOUNT: ./MxnExternalAccountInfo.yaml | ||
| MYR_ACCOUNT: ./MyrExternalAccountInfo.yaml | ||
| PIX_ACCOUNT: ./PixExternalAccountInfo.yaml | ||
| THB_ACCOUNT: ./ThbExternalAccountInfo.yaml | ||
| UPI_ACCOUNT: ./UpiExternalAccountInfo.yaml | ||
| USD_ACCOUNT: ./UsdExternalAccountInfo.yaml | ||
| VND_ACCOUNT: ./VndExternalAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
new account type discriminator values (BRL_ACCOUNT, DKK_ACCOUNT, HKD_ACCOUNT, etc.) are not defined in ExternalAccountType.yaml enum - this will cause validation errors
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 93:107
Comment:
new account type discriminator values (BRL_ACCOUNT, DKK_ACCOUNT, HKD_ACCOUNT, etc.) are not defined in `ExternalAccountType.yaml` enum - this will cause validation errors
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Additional Comments (3)
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 83:92
Comment:
discriminator mappings reference old file names (`CadAccountExternalAccountInfo.yaml`) but new account types (BRL_ACCOUNT, DKK_ACCOUNT, etc.) reference new file names (`BrlExternalAccountInfo.yaml`) - inconsistent naming pattern
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/BaseExternalAccountInfo.yaml
Line: 7:26
Comment:
discriminator mapping is missing new account types added in `ExternalAccountInfoOneOf.yaml` (BRL_ACCOUNT, DKK_ACCOUNT, HKD_ACCOUNT, IDR_ACCOUNT, INR_ACCOUNT, MXN_ACCOUNT, MYR_ACCOUNT, THB_ACCOUNT, USD_ACCOUNT, VND_ACCOUNT, and LIGHTNING_ACCOUNT)
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountType.yaml
Line: 1:21
Comment:
enum is missing new account type values referenced in discriminator mappings: BRL_ACCOUNT, CLABE_ACCOUNT, DKK_ACCOUNT, HKD_ACCOUNT, IBAN_ACCOUNT, IDR_ACCOUNT, INR_ACCOUNT, LIGHTNING_ACCOUNT, MXN_ACCOUNT, MYR_ACCOUNT, PIX_ACCOUNT, THB_ACCOUNT, UPI_ACCOUNT, USD_ACCOUNT, and VND_ACCOUNT
How can I resolve this? If you propose a fix, please make it concise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-synced account schemas.
These schemas are generated from VASP adapter field definitions in sparkcore.
Synced directories:
common/— per-currency account info and beneficiary schemasexternal_accounts/— per-currency external account schemas (reference common/)Please review the changes before merging.