Closed
Conversation
Contributor
Greptile OverviewGreptile SummaryThis PR auto-syncs account schemas from sparkcore VASP adapter field definitions, adding support for 14 new currencies (BRL, DKK, HKD, IDR, INR, MXN, MYR, THB, USD, VND) and updating the schema structure. Key Changes:
Critical Issues (persist from previous review):
Note: Since this is an auto-generated sync from sparkcore, these issues suggest the source system may need updates. The beneficiary field removal appears unintentional as newer currency schemas (BRL, DKK, HKD, etc.) correctly include beneficiary fields. Confidence Score: 2/5
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml | Updated file references from old naming convention (e.g., CadAccountExternalAccountInfo.yaml) to new convention (e.g., CadExternalAccountInfo.yaml), resolving the duplicate references issue flagged in previous review |
| openapi/components/schemas/external_accounts/CadExternalAccountInfo.yaml | New file missing required beneficiary field that was present in old CadAccountExternalAccountInfo.yaml - same issue persists from previous review |
| openapi/components/schemas/external_accounts/ClabeExternalAccountInfo.yaml | New file missing required beneficiary field that was present in old file - issue persists from previous review |
| openapi/components/schemas/external_accounts/IbanExternalAccountInfo.yaml | New file missing required beneficiary field that was present in old file - issue persists from previous review |
| openapi/components/schemas/external_accounts/PixExternalAccountInfo.yaml | New file missing required beneficiary field that was present in old file - issue persists from previous review |
| openapi/components/schemas/external_accounts/UpiExternalAccountInfo.yaml | New file missing required beneficiary field that was present in old file - issue persists from previous review |
| openapi/components/schemas/external_accounts/UsExternalAccountInfo.yaml | New file missing required beneficiary field that was present in old file - issue persists from previous review |
| openapi/components/schemas/external_accounts/NgnExternalAccountInfo.yaml | New file missing required beneficiary field that was present in old file - issue persists from previous review |
| openapi/components/schemas/common/GbpAccountInfo.yaml | Removed validation patterns, examples, min/max length constraints, and accountType field - less strict validation than previous version |
| openapi/components/schemas/common/SgdAccountInfo.yaml | Removed required swiftCode field, validation patterns, examples, and accountType field - significant schema simplification |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
14
to
73
| - title: CAD Account | ||
| $ref: ./CadAccountExternalAccountInfo.yaml | ||
| - title: GBP Account | ||
| $ref: ./GbpAccountExternalAccountInfo.yaml | ||
| - title: PHP Account | ||
| $ref: ./PhpAccountExternalAccountInfo.yaml | ||
| - title: SGD Account | ||
| $ref: ./SgdAccountExternalAccountInfo.yaml | ||
| - title: Spark Wallet | ||
| $ref: ./SparkWalletExternalAccountInfo.yaml | ||
| - title: Lightning | ||
| $ref: ./LightningExternalAccountInfo.yaml | ||
| - title: Solana Wallet | ||
| $ref: ./SolanaWalletExternalAccountInfo.yaml | ||
| - title: Tron Wallet | ||
| $ref: ./TronWalletExternalAccountInfo.yaml | ||
| - title: Polygon Wallet | ||
| $ref: ./PolygonWalletExternalAccountInfo.yaml | ||
| - title: Base Wallet | ||
| $ref: ./BaseWalletExternalAccountInfo.yaml | ||
| - title: Brl Account | ||
| $ref: ./BrlExternalAccountInfo.yaml | ||
| - title: Cad Account | ||
| $ref: ./CadExternalAccountInfo.yaml | ||
| - title: Clabe Account | ||
| $ref: ./ClabeExternalAccountInfo.yaml | ||
| - title: Dkk Account | ||
| $ref: ./DkkExternalAccountInfo.yaml | ||
| - title: Gbp Account | ||
| $ref: ./GbpExternalAccountInfo.yaml | ||
| - title: Hkd Account | ||
| $ref: ./HkdExternalAccountInfo.yaml | ||
| - title: Iban Account | ||
| $ref: ./IbanExternalAccountInfo.yaml | ||
| - title: Idr Account | ||
| $ref: ./IdrExternalAccountInfo.yaml | ||
| - title: Inr Account | ||
| $ref: ./InrExternalAccountInfo.yaml | ||
| - title: Mxn Account | ||
| $ref: ./MxnExternalAccountInfo.yaml | ||
| - title: Myr Account | ||
| $ref: ./MyrExternalAccountInfo.yaml | ||
| - title: Ngn Account | ||
| $ref: ./NgnExternalAccountInfo.yaml | ||
| - title: Php Account | ||
| $ref: ./PhpExternalAccountInfo.yaml | ||
| - title: Pix Account | ||
| $ref: ./PixExternalAccountInfo.yaml | ||
| - title: Sgd Account | ||
| $ref: ./SgdExternalAccountInfo.yaml | ||
| - title: Thb Account | ||
| $ref: ./ThbExternalAccountInfo.yaml | ||
| - title: Upi Account | ||
| $ref: ./UpiExternalAccountInfo.yaml | ||
| - title: Us Account | ||
| $ref: ./UsExternalAccountInfo.yaml | ||
| - title: Usd Account | ||
| $ref: ./UsdExternalAccountInfo.yaml | ||
| - title: Vnd Account | ||
| $ref: ./VndExternalAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
Duplicate account types in oneOf array — both old and new file references exist for CAD, CLABE, GBP, IBAN, NGN, PHP, PIX, SGD, UPI, and US accounts (e.g., CadAccountExternalAccountInfo.yaml on line 15 and CadExternalAccountInfo.yaml on line 37). This will cause schema validation issues.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 14:73
Comment:
Duplicate account types in `oneOf` array — both old and new file references exist for CAD, CLABE, GBP, IBAN, NGN, PHP, PIX, SGD, UPI, and US accounts (e.g., `CadAccountExternalAccountInfo.yaml` on line 15 and `CadExternalAccountInfo.yaml` on line 37). This will cause schema validation issues.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
1
to
10
| type: object | ||
| required: | ||
| - bankName | ||
| - swiftCode | ||
| - accountNumber | ||
| - accountType | ||
| - bankName | ||
| - accountNumber | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - SGD_ACCOUNT | ||
| bankName: | ||
| type: string | ||
| description: Name of the beneficiary's bank | ||
| example: DBS Bank Ltd | ||
| swiftCode: | ||
| type: string | ||
| description: SWIFT/BIC code (8 or 11 characters) | ||
| example: DBSSSGSG | ||
| minLength: 8 | ||
| maxLength: 11 | ||
| pattern: ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$ | ||
| description: The bank name of the bank | ||
| accountNumber: | ||
| type: string |
Contributor
There was a problem hiding this comment.
Removed swiftCode field entirely (was required in old schema), along with all validation patterns, examples, and the accountType field. The old schema required swiftCode with SWIFT/BIC validation. Verify this field removal is intentional.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/SgdAccountInfo.yaml
Line: 1:10
Comment:
Removed `swiftCode` field entirely (was required in old schema), along with all validation patterns, examples, and the `accountType` field. The old schema required `swiftCode` with SWIFT/BIC validation. Verify this field removal is intentional.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
1
to
10
| type: object | ||
| required: | ||
| - bankName | ||
| - accountNumber | ||
| - accountType | ||
| - bankName | ||
| - accountNumber | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - PHP_ACCOUNT | ||
| bankName: | ||
| type: string | ||
| description: Name of the beneficiary's bank | ||
| example: BDO Unibank | ||
| description: The bank name of the bank | ||
| accountNumber: | ||
| type: string |
Contributor
There was a problem hiding this comment.
Removed validation examples and the accountType field. Descriptions also changed from specific (e.g., "Name of the beneficiary's bank") to generic (e.g., "The bank name of the bank"). Verify these changes are intentional.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/PhpAccountInfo.yaml
Line: 1:10
Comment:
Removed validation examples and the `accountType` field. Descriptions also changed from specific (e.g., "Name of the beneficiary's bank") to generic (e.g., "The bank name of the bank"). Verify these changes are intentional.
How can I resolve this? If you propose a fix, please make it concise.
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript Edit this comment to update them. They will appear in their respective SDK's changelogs.
|
| ❗ Transform/Failed: Transform `remove` failed at step `8`. |
| ❗ Reference/NotFound: Ignored reference `#/components/schemas/UsAccountExternalAccountInfo` (not found in spec). |
| ❗ Reference/NotFound: Ignored reference `#/components/schemas/ClabeAccountExternalAccountInfo` (not found in spec). |
| ❗ Reference/NotFound: Ignored reference `#/components/schemas/PixAccountExternalAccountInfo` (not found in spec). |
| ❗ Reference/NotFound: Ignored reference `#/components/schemas/IbanAccountExternalAccountInfo` (not found in spec). |
| ❗ Reference/NotFound: Ignored reference `#/components/schemas/UpiAccountExternalAccountInfo` (not found in spec). |
| ❗ Reference/NotFound: Ignored reference `#/components/schemas/NgnAccountExternalAccountInfo` (not found in spec). |
| ❗ Reference/NotFound: Ignored reference `#/components/schemas/CadAccountExternalAccountInfo` (not found in spec). |
| ❗ Reference/NotFound: Ignored reference `#/components/schemas/GbpAccountExternalAccountInfo` (not found in spec). |
| ❗ Reference/NotFound: Ignored reference `#/components/schemas/PhpAccountExternalAccountInfo` (not found in spec). |
⚠️ grid-openapi studio · code · diff
There was a regression in your SDK.
generate ❗(prev:generate ✅)New diagnostics (12 error, 13 warning, 66 note)
❗ Transform/Failed: Transform `remove` failed at step `8`. ❗ Reference/NotFound: Ignored reference `#/components/schemas/UsAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/ClabeAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/PixAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/IbanAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/UpiAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/NgnAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/CadAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/GbpAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/PhpAccountExternalAccountInfo` (not found in spec).
⚠️ grid-kotlin studio · code · diff
There was a regression in your SDK.
generate ❗(prev:generate ✅) →build ⏳→lint ✅→test ⏳New diagnostics (12 error, 13 warning, 34 note)
❗ Transform/Failed: Transform `remove` failed at step `8`. ❗ Reference/NotFound: Ignored reference `#/components/schemas/UsAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/ClabeAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/PixAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/IbanAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/UpiAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/NgnAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/CadAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/GbpAccountExternalAccountInfo` (not found in spec). ❗ Reference/NotFound: Ignored reference `#/components/schemas/PhpAccountExternalAccountInfo` (not found in spec).
❗ grid-python studio
Code was not generated because there was a fatal error.
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-02-12 19:15:19 UTC
Comment on lines
+1
to
+3
| allOf: | ||
| - $ref: ./BaseExternalAccountInfo.yaml | ||
| - $ref: ../common/CadAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
Missing required beneficiary field. The old CadAccountExternalAccountInfo.yaml requires a beneficiary with $ref: ./BeneficiaryOneOf.yaml. This new file should include:
Suggested change
| allOf: | |
| - $ref: ./BaseExternalAccountInfo.yaml | |
| - $ref: ../common/CadAccountInfo.yaml | |
| allOf: | |
| - $ref: ./BaseExternalAccountInfo.yaml | |
| - $ref: ../common/CadAccountInfo.yaml | |
| - type: object | |
| required: | |
| - beneficiary | |
| properties: | |
| beneficiary: | |
| $ref: ./BeneficiaryOneOf.yaml |
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/CadExternalAccountInfo.yaml
Line: 1:3
Comment:
Missing required `beneficiary` field. The old `CadAccountExternalAccountInfo.yaml` requires a beneficiary with `$ref: ./BeneficiaryOneOf.yaml`. This new file should include:
```suggestion
allOf:
- $ref: ./BaseExternalAccountInfo.yaml
- $ref: ../common/CadAccountInfo.yaml
- type: object
required:
- beneficiary
properties:
beneficiary:
$ref: ./BeneficiaryOneOf.yaml
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+1
to
+3
| allOf: | ||
| - $ref: ./BaseExternalAccountInfo.yaml | ||
| - $ref: ../common/ClabeAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
Missing required beneficiary field - same issue as CAD, IBAN, NGN, PIX, UPI, and US accounts.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ClabeExternalAccountInfo.yaml
Line: 1:3
Comment:
Missing required `beneficiary` field - same issue as CAD, IBAN, NGN, PIX, UPI, and US accounts.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+1
to
+3
| allOf: | ||
| - $ref: ./BaseExternalAccountInfo.yaml | ||
| - $ref: ../common/IbanAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
Missing required beneficiary field - same issue as CAD, CLABE, NGN, PIX, UPI, and US accounts.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/IbanExternalAccountInfo.yaml
Line: 1:3
Comment:
Missing required `beneficiary` field - same issue as CAD, CLABE, NGN, PIX, UPI, and US accounts.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+1
to
+3
| allOf: | ||
| - $ref: ./BaseExternalAccountInfo.yaml | ||
| - $ref: ../common/NgnAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
Missing required beneficiary field - same issue as CAD, CLABE, IBAN, PIX, UPI, and US accounts.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/NgnExternalAccountInfo.yaml
Line: 1:3
Comment:
Missing required `beneficiary` field - same issue as CAD, CLABE, IBAN, PIX, UPI, and US accounts.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+1
to
+3
| allOf: | ||
| - $ref: ./BaseExternalAccountInfo.yaml | ||
| - $ref: ../common/PixAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
Missing required beneficiary field - same issue as CAD, CLABE, IBAN, NGN, UPI, and US accounts.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/PixExternalAccountInfo.yaml
Line: 1:3
Comment:
Missing required `beneficiary` field - same issue as CAD, CLABE, IBAN, NGN, UPI, and US accounts.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+1
to
+3
| allOf: | ||
| - $ref: ./BaseExternalAccountInfo.yaml | ||
| - $ref: ../common/UpiAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
Missing required beneficiary field - same issue as CAD, CLABE, IBAN, NGN, PIX, and US accounts.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/UpiExternalAccountInfo.yaml
Line: 1:3
Comment:
Missing required `beneficiary` field - same issue as CAD, CLABE, IBAN, NGN, PIX, and US accounts.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+1
to
+3
| allOf: | ||
| - $ref: ./BaseExternalAccountInfo.yaml | ||
| - $ref: ../common/UsAccountInfo.yaml |
Contributor
There was a problem hiding this comment.
Missing required beneficiary field - same issue as CAD, CLABE, IBAN, NGN, PIX, and UPI accounts.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/UsExternalAccountInfo.yaml
Line: 1:3
Comment:
Missing required `beneficiary` field - same issue as CAD, CLABE, IBAN, NGN, PIX, and UPI accounts.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-synced account schemas.
These schemas are generated from VASP adapter field definitions in sparkcore.
Synced directories:
common/— per-currency account info and beneficiary schemasexternal_accounts/— per-currency external account schemas (reference common/)Please review the changes before merging.