feat: adding external account verification to UPI accounts#169
feat: adding external account verification to UPI accounts#169
Conversation
✱ Stainless preview buildsThis PR will update the Edit this comment to update it. It will appear in the SDK's changelogs. ✅ grid-typescript studio · code · diff
✅ grid-kotlin studio · code · diff
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Greptile OverviewGreptile SummaryThis PR updates the Stainless SDK generation configuration (organization name, TS/Kotlin package metadata, production repo targets) and adjusts how schema unions/discriminators are handled by removing discriminator properties from several base schemas to avoid It also updates the OpenAPI specs (root + mintlify + split spec) by:
These changes affect both the published API docs (mintlify) and the SDK generation pipeline (Stainless), so correctness of the schema transforms and generated README example requests is important. Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| .stainless/stainless.yml | Updates org/package/repo settings and adds OpenAPI transformations that strip discriminator fields and remove empty base allOf refs. |
| mintlify/openapi.yaml | Updates Exchange Rates tag description and adds beneficiaryNameVerificationStatus to UpiAccountExternalAccountInfo schema. |
| openapi.yaml | Mirrors mintlify OpenAPI changes: shortens Exchange Rates tag description and adds beneficiaryNameVerificationStatus to UpiAccountExternalAccountInfo. |
| openapi/components/schemas/external_accounts/UpiAccountExternalAccountInfo.yaml | Adds beneficiaryNameVerificationStatus enum field to UPI external account info; file currently lacks trailing newline. |
| openapi/openapi.yaml | Shortens Exchange Rates tag description in the split OpenAPI spec. |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Stainless as Stainless (config + transforms)
participant Spec as OpenAPI (openapi.yaml)
participant SDK as Generated SDKs (TS/Kotlin)
Dev->>Stainless: Update .stainless/stainless.yml (org/package/repos)
Dev->>Spec: Add beneficiaryNameVerificationStatus to UPI external account info
Stainless->>Spec: Apply transformations (remove discriminator $refs, remove allOf base $refs)
Stainless->>SDK: Generate SDKs + README snippets
SDK-->>Dev: SDK types compile (type conflicts reduced)
SDK-->>Dev: README snippets depend on example request validity
Additional Comments (2)
This file ends without a final newline (shows up as Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/UpiAccountExternalAccountInfo.yaml
Line: 1:3
Comment:
**Missing trailing newline**
This file ends without a final newline (shows up as `\ No newline at end of file` in the diff). Some tooling (formatters/linters, schema bundlers, and CI diffs) treats this as a formatting error; please add a trailing newline to avoid noisy diffs/failures.
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix With AIThis is a comment left during a code review.
Path: .stainless/stainless.yml
Line: 287:290
Comment:
**Invalid README example call**
`.stainless/stainless.yml` switches the README `default`/`headline` snippets to `post /quotes` but leaves `params: {}`. In the spec, `POST /quotes` requires a request body (it’s not an empty request), so this example request will generate SDK README snippets that don’t compile/run against the generated client. Update the example to include the required body fields (or point the snippet back at an endpoint that supports an empty request).
How can I resolve this? If you propose a fix, please make it concise. |

TL;DR
Updated Stainless configuration for Lightspark Grid SDK, fixing type conflicts and adding beneficiary name verification status.
What changed?
beneficiaryNameVerificationStatusfield to UPI account external account info/quotesendpoint instead of/config