Add total_consistency_lock check in handle_post_event_actions
#4329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 I see @joostjager was un-assigned. |
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
Needs rustfmt CI fix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4329 +/- ##
=======================================
Coverage 86.53% 86.53%
=======================================
Files 158 158
Lines 103188 103190 +2
Branches 103188 103190 +2
=======================================
+ Hits 89292 89300 +8
+ Misses 11471 11469 -2
+ Partials 2425 2421 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We expect callers of `handle_post_event_actions` to hold a read lock on `total_consistency_lock`, and found that we forgot it in `process_pending_events` until recently. Here we add a relevant assertion to avoid such issues in the future.
TheBlueMatt
force-pushed
the
2026-01-actions-lock-assert
branch
from
5461ac6 to
8bdd1fa
Compare
TheBlueMatt
requested review from
valentinewallace
and removed request for
joostjager
valentinewallace
approved these changes
Jan 21, 2026
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
CI failure looks unrelated
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
wpaulino
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect callers of
handle_post_event_actionsto hold a read lock ontotal_consistency_lock, and found that we forgot it inprocess_pending_eventsuntil recently. Here we add a relevant assertion to avoid such issues in the future.