Skip to content

Conversation

@joostjager
Copy link
Contributor

Small readability improvement

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Dec 19, 2025

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@joostjager joostjager force-pushed the update-handling-refactor branch from dd25afd to f687020 Compare December 19, 2025 09:10
@joostjager joostjager changed the title Convert internal update handling methods to methods Convert internal update handling fns to methods Dec 19, 2025
Pure code move except for the context logger which is now instantiated
when needed in handle_monitor_update_internal.
@joostjager joostjager force-pushed the update-handling-refactor branch from f687020 to dfbf531 Compare December 19, 2025 09:18
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.38%. Comparing base (62c5849) to head (dfbf531).

Files with missing lines Patch % Lines
lightning/src/ln/channelmanager.rs 90.56% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4291   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files         180      180           
  Lines      139834   139836    +2     
  Branches   139834   139836    +2     
=======================================
+ Hits       124985   124989    +4     
+ Misses      12262    12259    -3     
- Partials     2587     2588    +1     
Flag Coverage Δ
fuzzing 35.22% <75.47%> (+<0.01%) ⬆️
tests 88.71% <86.79%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joostjager joostjager marked this pull request as ready for review December 19, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants