Skip to content

Do not use buffered writers to write lines to the log file #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benthecarman merged 1 commit into from
Dec 20, 2025
Merged

Do not use buffered writers to write lines to the log file #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ldk-server/src/util/logger.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

use log::{Level, LevelFilter, Log, Metadata, Record};
use std::fs::{self, File, OpenOptions};
use std::io::{self, BufWriter, Write};
use std::io::{self, Write};
use std::path::{Path, PathBuf};
use std::sync::{Arc, Mutex};

Expand All @@ -29,7 +29,7 @@ pub struct ServerLogger {
/// The maximum log level to display
level: LevelFilter,
/// The file to write logs to, protected by a mutex for thread-safe access
file: Mutex<BufWriter<File>>,
file: Mutex<File>,
/// Path to the log file for reopening on SIGHUP
log_file_path: PathBuf,
}
Expand Down Expand Up @@ -155,9 +155,8 @@ fn format_level(level: Level) -> &'static str {
}
}

fn open_log_file(log_file_path: &Path) -> Result<BufWriter<File>, io::Error> {
let file = OpenOptions::new().create(true).append(true).open(log_file_path)?;
Ok(BufWriter::new(file))
fn open_log_file(log_file_path: &Path) -> Result<File, io::Error> {
OpenOptions::new().create(true).append(true).open(log_file_path)
}

/// Wrapper to allow Arc<ServerLogger> to implement Log trait
Expand Down