Make expiry_secs optional for bolt11-receive #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @benthecarman as a reviewer! |
ldk-server-cli/src/main.rs
Outdated
| const DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA: u32 = 1008; | ||
| const DEFAULT_MAX_PATH_COUNT: u32 = 10; | ||
| const DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF: u32 = 2; | ||
| const DEFAULT_EXPIRY_SECS: u32 = 3600; |
Collaborator
There was a problem hiding this comment.
can we do default to 86_400
elnosh
force-pushed
the
expiry-secs-optional
branch
from
4451d45 to
28d1490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a default - kind of annoying that is required