Expose introduction node direction in decoded offers#213
Merged
Conversation
|
👋 Thanks for assigning @benthecarman as a reviewer! |
A BOLT12 blinded path's introduction node may be identified by a directed short channel ID (SCID plus a direction byte selecting one of the channel's two endpoints), not just by node id. Previously the decoded offer dropped the direction byte, leaving callers unable to tell which endpoint was the introduction node. The two identification forms were also represented as independent optional fields, so the schema did not enforce that exactly one was set; mutual exclusivity relied on server convention. Restructure `BlindedPath` so the introduction node is a `oneof` between a `node_id` string and a new `DirectedShortChannelId` message carrying both the SCID and a `ChannelDirection` enum. Populate it from the LDK `IntroductionNode::DirectedShortChannelId` variant. Co-Authored-By: Claude <noreply@anthropic.com>
jkczyz
force-pushed
the
2026-05-directed-scid
branch
from
f1c293b to
499a6c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A BOLT12 blinded path's introduction node may be identified by a directed short channel ID (SCID plus a direction byte selecting one of the channel's two endpoints), not just by node id. Previously the decoded offer dropped the direction byte, leaving callers unable to tell which endpoint was the introduction node. The two identification forms were also represented as independent optional fields, so the schema did not enforce that exactly one was set; mutual exclusivity relied on server convention.
Restructure
BlindedPathso the introduction node is aoneofbetween anode_idstring and a newDirectedShortChannelIdmessage carrying both the SCID and aChannelDirectionenum. Populate it from the LDKIntroductionNode::DirectedShortChannelIdvariant.