Skip to content

Conversation

@tnull
Copy link
Collaborator

@tnull tnull commented Aug 21, 2025

Fixes #624.

Google announced that starting Nov 2025 all apps in the Play Store will be required to be compatible with 16KB page sizes (cf. https://developer.android.com/guide/practices/page-sizes). Here we update our linker flags to ensure the generated shared libraries meet that requirement.

Google announced that starting Nov 2025 all apps in the Play Store will
be required to be compatible with 16KB page sizes (cf.
https://developer.android.com/guide/practices/page-sizes). Here we
update our linker flags to ensure the generated shared libraries meet
that requirement.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Aug 21, 2025

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull tnull requested a review from TheBlueMatt August 21, 2025 10:01
Copy link
Contributor

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where'd you get the common-page-size option from? The Google docs seem to indicate we only need the max-page-size option.

@tnull
Copy link
Collaborator Author

tnull commented Aug 21, 2025

Where'd you get the common-page-size option from? The Google docs seem to indicate we only need the max-page-size option.

They mention it here for NDK r22 and lower: https://developer.android.com/guide/practices/page-sizes#compile-r22-lower
I guess it's not necessary for us strictly, do you think there will be a drawback from setting it? Seemed reasonable given 16kb will be the standard going forward after Android 15+, IIUC?

@tnull tnull requested a review from TheBlueMatt August 21, 2025 15:38
@tnull tnull merged commit fdaa759 into lightningdevkit:main Aug 21, 2025
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check Android builds fulfill 16kb page size requirements

3 participants