Skip to content

Conversation

@tnull
Copy link
Collaborator

@tnull tnull commented Aug 15, 2025

.. we make the required changes to ship v0.6.2 bindings.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Aug 15, 2025

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull tnull requested a review from TheBlueMatt August 15, 2025 09:15
@tnull tnull force-pushed the 2025-08-cut-v0.6.2-bindings branch 2 times, most recently from b7a2926 to 4308a9d Compare August 15, 2025 09:33
tnull added 2 commits August 15, 2025 11:43
Maven Central recently deprecated the Sonatype-style publishing, which
means the nexus publishing gradle plugin we used didn't work anymore. As
Maven Central has yet to release a replacement plugin for gradle, we
simply drop nexus publishing support here and manually upload the
archives in the meantime, which is simple enough.

We also drop the publishing CI jobs that originally aimed to automate
publishing to Maven Central, which we however never came around to use
since we didn't want to fully trust Github CI with publishing binaries
for us.
.. which we use before manually publishing to Maven Central.
@tnull tnull force-pushed the 2025-08-cut-v0.6.2-bindings branch from 4308a9d to f481f07 Compare August 15, 2025 09:43

let tag = "v0.6.2"
let checksum = "73f53b615d5bfdf76f2e7233bde17a2a62631292ce506763a7150344230859c8"
let checksum = "dee28eb2bc019eeb61cc28ca5c19fdada465a6eb2b5169d2dbaa369f0c63ba03"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to verify this, but sure.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, at some point we should look if we can at least make parts of the build process reproducible. For now you could compare it to the zip file I just uploaded as part of the release, but Xcode already does that when importing the dependency.

@tnull tnull merged commit 0b99977 into lightningdevkit:release/0.6 Aug 15, 2025
14 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants