Skip to content

Conversation

@benthecarman
Copy link
Contributor

This is useful if the esplora server has a form of authentication in front of it

@benthecarman benthecarman requested a review from tnull July 18, 2025 21:48
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jul 18, 2025

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot
Copy link

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, makes sense to me.

LGTM, one tiny nit.

This is useful if the esplora server has a form of authentication in
front of it
Copy link
Contributor

@enigbe enigbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnull tnull merged commit d7226f3 into lightningdevkit:main Jul 22, 2025
15 checks passed
@benthecarman benthecarman deleted the esplora-headers branch July 22, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants