Bump uniffi dependency to v0.28.3
#591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We bump our `uniffi` dependency to v0.28.3 to unlock some of the nicer features `uniffi` added since the previously-used v0.27.3. However, we can't bump it further to v0.29.3, as we have users requiring compatibility with `uniffi-bindgen-go`, which only supports v0.28.3 at the time of writing.
|
I've assigned @tankyleo as a reviewer! |
enigbe
approved these changes
Jul 1, 2025
tankyleo
approved these changes
Jul 2, 2025
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
Not familiar with uniffi myself, reproduced the diff on my machine, things seem to be working, and also ran successfully scripts/uniffi_bindgen_generate_python.sh and scripts/uniffi_bindgen_generate_kotlin.sh.
Likely I am missing some dependencies for scripts/uniffi_bindgen_generate_swift.sh and scripts/uniffi_bindgen_generate_kotlin_android.sh
Also double checked uniffi-bindgen-go and indeed the README says "Currently, uniffi-bindgen-go uses uniffi-rs version 0.28.3".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We bump our
uniffidependency to v0.28.3 to unlock some of the nicer featuresuniffiadded since the previously-used v0.27.3. However, we can't bump it further to v0.29.3, as we have users requiring compatibility withuniffi-bindgen-go, which only supports v0.28.3 at the time of writing.