-
Notifications
You must be signed in to change notification settings - Fork 114
Continue receive flow on offer/invoice creation failure #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue receive flow on offer/invoice creation failure #548
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please also change the docs to match the new behavior. Also, can we add test coverage for this?
Thanks, I will make this update |
ddda6e5 to
72ee31a
Compare
Hello @tnull, the docs and test coverage have been updated |
enigbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this and the changes LGTM.
tnull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nits basically.
You'll also need to run cargo fmt to make the CI happy.
652ad4a to
03e065e
Compare
03e065e to
e396a1a
Compare
tnull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Continue receive flow when
BOLT12 offerorBOLT11 invoicecreation fails, logging errors butallowing onchain
BIP21as fallback.Fixes #476