Fix module_path/line numbers in log facade logging
#547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we'd reuse the `log` facade macros which would always log the line number in `logger.rs`, not at the line number given at the record. Here, we rectify this by utilizing `log`'s `RecordBuilder` to craft a record and directly giving it to the configured logger.
|
I've assigned @jkczyz as a reviewer! |
jkczyz
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we'd reuse the
logfacade macros which would always log the line number inlogger.rs, not at the line number given at the record.Here, we rectify this by utilizing
log'sRecordBuilderto craft a record and directly giving it to the configured logger.