Skip to content

Conversation

@Camillarhi
Copy link
Contributor

This PR integrates the bitcoin_payment_instructions crate while maintaining backward compatibility:

  • Integrated bitcoin_payment_instructions crate for better payment URI parsing
  • Maintained sync API while using Tokio's runtime internally
  • Kept existing payment fallback logic (BOLT12 → BOLT11 → Onchain)
  • Added proper error handling for new parser

Fixes #521

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented May 25, 2025

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@Camillarhi Camillarhi force-pushed the bitcoin-payment-instructions-switch branch from 559296d to 4a02cc7 Compare May 25, 2025 19:24
@ldk-reviews-bot ldk-reviews-bot requested a review from jkczyz May 25, 2025 19:32
@Camillarhi Camillarhi marked this pull request as draft May 25, 2025 19:36
@tnull tnull requested review from tnull and removed request for jkczyz May 26, 2025 09:00
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in this! As mentioned over at #521, I think it however makes sense to do this as part of/after the ongoing HRN work. So unfortunately I don't think it makes sense to just switch parts of the code over before we do the HRN integration. Going ahead and closing this.

@tnull tnull closed this May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to use bitcoin-payment-instructions

3 participants