Skip to content

Conversation

@tnull
Copy link
Collaborator

@tnull tnull commented Apr 28, 2025

We cut the v0.5 Rust release.

As we'll wait for LDK 0.1.3 to ship, the Kotlin/Swift binary releases will follow in a separate PR.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Apr 28, 2025

👋 I see @jkczyz was un-assigned.
If you'd like another reviewer assignemnt, please click here.

@tnull tnull marked this pull request as draft April 28, 2025 12:42
@tnull tnull force-pushed the 2025-04-cut-0.5.0 branch 2 times, most recently from e60c57f to f130430 Compare April 29, 2025 07:59
@tnull tnull force-pushed the 2025-04-cut-0.5.0 branch 2 times, most recently from d8dd81d to f2d0466 Compare April 29, 2025 08:09
@tnull tnull marked this pull request as ready for review April 29, 2025 08:09
@tnull tnull changed the title Cut v0.5.0 release Cut v0.5.0 Rust release Apr 29, 2025
@ldk-reviews-bot ldk-reviews-bot requested a review from jkczyz April 29, 2025 08:09
@tnull tnull requested review from joostjager and removed request for jkczyz April 29, 2025 08:10
Copy link
Contributor

@joostjager joostjager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that I find a bit scary is Rust's auto-upgrade of patches. I saw ldk 0.1.0 is referenced in cargo.toml, which then I think auto-upgrades. But it makes the release non-deterministic? I suppose that's just the Rust way of doing it.

@tnull tnull mentioned this pull request Apr 29, 2025
@tnull
Copy link
Collaborator Author

tnull commented Apr 29, 2025

One thing that I find a bit scary is Rust's auto-upgrade of patches. I saw ldk 0.1.0 is referenced in cargo.toml, which then I think auto-upgrades. But it makes the release non-deterministic? I suppose that's just the Rust way of doing it.

It's a feature. For example, it allows us to ship the release now, and our users will get the LDK 0.1.3 fixes 'for free' as soon as it ships.

@tnull tnull merged commit fe2b026 into lightningdevkit:release/0.5 Apr 29, 2025
15 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants