-
Notifications
You must be signed in to change notification settings - Fork 114
Allow forwarding to unannounced channels if LSP service is enabled #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -675,11 +675,14 @@ where | |
|
|
||
| let mut config = *self.channel_manager.get_current_default_configuration(); | ||
|
|
||
| // Set the HTLC-value-in-flight to 100% of the channel value to ensure we can | ||
| // forward the payment. | ||
| config | ||
| .channel_handshake_config | ||
| .max_inbound_htlc_value_in_flight_percent_of_channel = 100; | ||
| // We set these LSP-specific values during Node building, here we're making sure it's actually set. | ||
| debug_assert_eq!( | ||
| config | ||
| .channel_handshake_config | ||
| .max_inbound_htlc_value_in_flight_percent_of_channel, | ||
| 100 | ||
| ); | ||
| debug_assert!(config.accept_forwards_to_priv_channels); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems quite defensive. Is it really needed?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yup, in this case I'd prefer to make sure it is set. The issue is that we have 2-3 |
||
|
|
||
| // We set the forwarding fee to 0 for now as we're getting paid by the channel fee. | ||
| // | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.