Network graph update error logging #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostjager
commented
Jan 31, 2025
src/gossip.rs
Outdated
| .map_err(|_| Error::GossipUpdateFailed)?; | ||
| let new_latest_sync_timestamp = | ||
| gossip_sync.update_network_graph(&update_data).map_err(|e| { | ||
| log_trace!(logger, "Failed to update network graph with RGS data: {:?}", e); |
Contributor
Author
There was a problem hiding this comment.
Not sure if {:?} is desired? Otherwise need to add Display to (nested) errors.
Otherwise a basic error such as wrong chainhash isn't surfaced, making debugging harder.
joostjager
force-pushed
the
log-rgs-update-error
branch
from
33e06d3 to
4501b61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.