core: fixing the esplora error match #416
Conversation
vincenzopalazzo
force-pushed
the
macros/esplora-api
branch
2 times, most recently
from
afd7cda to
4e5d678
Compare
Recent version of esplora (from v0.10) changed the error type, so this commit is reflecting the change. Link: lightningdevkit#412 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/esplora-api
branch
from
4e5d678 to
6eee955
Compare
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
|
Ok looks like that github has my force push stuck https://github.blog/changelog/2023-09-26-more-details-provided-when-a-pull-request-is-merged-indirectly-or-is-still-processing-updates/ let me know if this does not change at the time that you review it |
| chrono = { version = "0.4", default-features = false, features = ["clock"] } | ||
| tokio = { version = "1.37", default-features = false, features = [ "rt-multi-thread", "time", "sync", "macros" ] } | ||
| esplora-client = { version = "0.9", default-features = false } | ||
| esplora-client = { version = "0.10", default-features = false } |
There was a problem hiding this comment.
Please don't just arbitrarily bump crates. Bumping should always happen in dedicated commits at least and only if we see necessity to do so. In this specific case, our esplora-client version needs to match the one in lightning-transaction-sync, so we can only bump it as part of the next LDK upgrade (after LDK is upgraded, that is).
There was a problem hiding this comment.
I removed it. It was just a test, but github is stuck for some reason the update branch is https://github.com/vincenzopalazzo/ldk-node/tree/macros/esplora-api
|
Ok looks like that the PR is still stuck? so closing this and opening a new one that reflect my fork https://github.com/vincenzopalazzo/ldk-node/tree/macros/esplora-api |
2 participants
I am wondering if we should also fix the FIXME message in the following PR with an extra commit?
What do you like to differentiate based on the error message?
Fixes #412