revert: removes date from & symlink to log files #394
Conversation
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
57a04f1 to
ee51f47
Compare
) This commit reverts the changes introduce by PR lightningdevkit#116 which added the date to log files when the node is started & a symlink to track the latest log file. This reversal is necessary to simplify the work required to integrate with OS-level log tools.
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
ee51f47 to
24cf565
Compare
| /// the existing log file. | ||
| fn setup_logger(config: &Config) -> Result<Arc<FilesystemLogger>, BuildError> { | ||
| let log_dir = match &config.log_dir_path { | ||
| Some(log_dir) => String::from(log_dir), |
There was a problem hiding this comment.
Github won't comment on the line below this, but let's drop the {storage_path_dir}/logs folder now that we'll only have one log file. Rather, let's just default to {storage_path_dir}/ldk_node.log.
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
109ab9c to
c030775
Compare
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
c030775 to
dc9f840
Compare
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Basically LGTM I think.
One question, up to to you.
- In addition, update docs for `ArcedNodeBuilder::set_log_file_path`
|
Thank you for the updates, mind rebasing on |
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
2 times, most recently
from
fc4aeb9 to
1eedcce
Compare
enigbe
force-pushed
the
revert-filesystem-logging-to-simple-file
branch
from
1eedcce to
f033ba2
Compare
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Thanks, LGTM.
There is one minor nit, but given that we'll do larger refactoring on this anyways, this can be addressed some other time.
| fn setup_logger(config: &Config) -> Result<Arc<FilesystemLogger>, BuildError> { | ||
| let log_dir = match &config.log_dir_path { | ||
| let log_file_path = match &config.log_file_path { | ||
| Some(log_dir) => String::from(log_dir), |
There was a problem hiding this comment.
nit: This variable names should be adjusted to reflect it's now a file path, not the dir path anymore.
There was a problem hiding this comment.
Apologies for this. I'll address in another PR.
There was a problem hiding this comment.
No worries at all, let's just include a fixup commit in whatever logging-related PR you open next!
2 participants
What this PR does:
Reverts the changes introduce by #116 which added the dates to log files whenever the node is started & a symlink to track the latest log file. This reversal is necessary to simplify the work required to integrate with OS-level log tools.
Related Issue
loggerinterface #309