Use a dedicated SDF render-op flag instead of overloading isCoreNode#791
Merged
Conversation
|
|
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on removing sdfRenderOp and object creation reduction
Use a dedicated SDF render-op flag instead of overloading May 11, 2026
isCoreNode
jfboeve
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoreTextNodewas taking the SDF-specific branch by overridingisCoreNode, which also changed earlier RTT framebuffer selection inbindRenderOp. That coupling could produce incorrectu_resolution/u_pixelRatiofor SDF text rendered under an RTT parent.What changed
isSdfRenderOpsignal on render ops.WebGlShaderProgramto useisSdfRenderOpinstead ofisCoreNode.CoreTextNodeto the normal core-node framebuffer path so RTT parent dimensions continue to be used for resolution selection.Behavioral impact
Regression coverage
Illustrative change