-
Notifications
You must be signed in to change notification settings - Fork 32
Feature(v3) refactored zIndexing #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wouterlucas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are we mixing children that have a zIndex value and ones that do not (thus are null)?
Are we doing sorted first, unsorted after? Assuming all unsorted are below the sorted ones?
…t to fall in line with css and renderer 2
wouterlucas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR should reduce the zIndexing strain we have upon node creation. Especially when using either or the same zIndex values in one parent node.
To do: