feat: CircuitBreaker vote#629
Open
failingtwice wants to merge 20 commits into
Open
Conversation
iamnp
reviewed
May 26, 2026
iamnp
reviewed
May 26, 2026
iamnp
reviewed
May 26, 2026
iamnp
reviewed
May 26, 2026
iamnp
reviewed
Jun 1, 2026
iamnp
reviewed
Jun 2, 2026
failingtwice
force-pushed
the
circuit-breaker-vote
branch
from
a9216a4 to
ae29064
Compare
failingtwice
force-pushed
the
circuit-breaker-vote
branch
from
ae29064 to
cbc2970
Compare
iamnp
reviewed
Jun 2, 2026
| ) | ||
|
|
||
| # getPeriodState before enactment, to compare against the expected post-enactment change. | ||
| lol_spent_before, lol_spendable_before, _, _ = lol_registry.getPeriodState() |
Contributor
There was a problem hiding this comment.
validate timestamps against LOL_PERIOD_START_AFTER...
| ) | ||
|
|
||
| # RESUME_ROLE: untouched by the DG proposal. | ||
| if pre_dg_resume_role_holders: |
Contributor
There was a problem hiding this comment.
- if this
ifevaluates to false - should it be asserted? - same q for pre_dg_cb_globals
- pre_dg_lol_period_state - the values inside this object are never
ifed
in general - i think we should
a. leave only pre_dg_resume_role_holders object - only pre_dg_resume_role_holders has dynamic keys, having other 2 objects and copying date to it seems to be redundand
b. run after-dg tests inside "if details["status"] != PROPOSAL_STATUS["executed"]:" statement so that before- values are always available and we do not expect them to be empty; this is ok because we do not run these tests once the proposal is enacted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.