fix: Report minor typo#19
Open
JiwaniZakir wants to merge 1 commit into
Open
Conversation
|
Thanks for the detailed fix. This matches my understanding — offset 8 is correct based on the field layout. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 29.69% 21.96% -7.74%
==========================================
Files 38 38
Lines 8631 8561 -70
Branches 1996 1979 -17
==========================================
- Hits 2563 1880 -683
- Misses 5643 6373 +730
+ Partials 425 308 -117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Glad it matches your understanding @lottoian — thanks for confirming! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
Corrects an incorrect byte offset in the named key v1.1 structure table within
documentation/Windows NT Registry File (REGF) format.asciidoc. The "Last (key) written date and time" field was documented at offset 10, but the correct offset is 8, as the preceding fields (signature at offset 4, size 2; flags at offset 6, size 2) only span bytes 4-7. Updates the offset value from10to8in the AsciiDoc table. Verified by cross-checking the field layout against adjacent offsets (16 for Unknown, 20 for Parent key offset) which remain consistent with the corrected value.