Skip to content

Fix Windows 7 incompatibility caused by linking windowsapp #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youw merged 1 commit into from
May 19, 2026
Merged

Fix Windows 7 incompatibility caused by linking windowsapp #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ if(EMSCRIPTEN)
enable_language(CXX)
endif()

message("Building usb-1.0 for: ${CMAKE_SYSTEM_NAME}")
message(STATUS "Building usb-1.0 for: ${CMAKE_SYSTEM_NAME}")

# This function generates all the local variables what end up getting written to config.
# We use a function as any vars set in this context don't mess with the rest of the file.
Expand Down Expand Up @@ -192,7 +192,15 @@ if(WIN32)
$<$<C_COMPILER_ID:MSVC>:${LIBUSB_ROOT}/libusb-1.0.rc>
)
target_compile_definitions(usb-1.0 PRIVATE $<$<C_COMPILER_ID:MSVC>:_CRT_SECURE_NO_WARNINGS=1>)
target_link_libraries(usb-1.0 PRIVATE windowsapp)

if(CMAKE_SYSTEM_NAME STREQUAL "WindowsStore")
# UWP/Store builds require the WindowsApp umbrella library
target_link_libraries(usb-1.0 PRIVATE windowsapp)
else()
# windowsapp pulls in API-set imports unavailable on Windows 7
target_link_libraries(usb-1.0 PRIVATE kernel32 user32)
endif()
Comment thread
Youw marked this conversation as resolved.

if(LIBUSB_ENABLE_WINDOWS_HOTPLUG)
target_sources(usb-1.0 PRIVATE
"${LIBUSB_ROOT}/os/windows_hotplug.c"
Expand Down
Loading