Skip to content

linux: Parse HID_FIRMWARE_VERSION from uevent for release_number #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohnAZoidberg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

linux: Parse HID_FIRMWARE_VERSION from uevent for release_number #777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions linux/hid.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,8 @@ static int get_hid_report_descriptor_from_hidraw(hid_device *dev, struct hidraw_
*/
static int parse_uevent_info(const char *uevent, unsigned *bus_type,
unsigned short *vendor_id, unsigned short *product_id,
char **serial_number_utf8, char **product_name_utf8)
char **serial_number_utf8, char **product_name_utf8,
unsigned short *version)
{
char tmp[1024];

Expand Down Expand Up @@ -622,6 +623,9 @@ static int parse_uevent_info(const char *uevent, unsigned *bus_type,
/* The caller has to free the serial number */
*serial_number_utf8 = strdup(value);
found_serial = 1;
} else if (strcmp(key, "HID_FIRMWARE_VERSION") == 0) {
/* Device version from kernel */
Comment on lines +626 to +627
Copy link
Member

@Youw Youw Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you could add a comment what kernel version this become available (with reference) - that would be great

Copy link
Author

@JohnAZoidberg JohnAZoidberg Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can wait until either Mario or my patch gets merged and I can add a comment

*version = (unsigned short)strtol(value, NULL, 16);
}

next_line:
Expand All @@ -648,6 +652,7 @@ static struct hid_device_info * create_device_info_for_device(struct udev_device
char *serial_number_utf8 = NULL;
char *product_name_utf8 = NULL;
unsigned bus_type;
unsigned short hid_version = 0;
int result;
struct hidraw_report_descriptor report_desc;

Expand All @@ -670,7 +675,8 @@ static struct hid_device_info * create_device_info_for_device(struct udev_device
&dev_vid,
&dev_pid,
&serial_number_utf8,
&product_name_utf8);
&product_name_utf8,
&hid_version);

if (!result) {
/* parse_uevent_info() failed for at least one field. */
Expand Down Expand Up @@ -709,7 +715,7 @@ static struct hid_device_info * create_device_info_for_device(struct udev_device
cur_dev->serial_number = utf8_to_wchar_t(serial_number_utf8);

/* Release Number */
cur_dev->release_number = 0x0;
cur_dev->release_number = hid_version;

/* Interface Number */
cur_dev->interface_number = -1;
Expand Down
Loading