Skip to content

Fix Coverity CID 1530056: sanitize tainted allocation size in hid_report_reconstructor_test.c #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youw merged 2 commits into from
Mar 9, 2026
Merged

Fix Coverity CID 1530056: sanitize tainted allocation size in hid_report_reconstructor_test.c #776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bfe1ff
Initial plan
Copilot Mar 9, 2026
40bdfa5
Fix Coverity CID 1530056: validate tainted allocation size before malloc
Copilot Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions windows/test/hid_report_reconstructor_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,11 @@ static hidp_preparsed_data * alloc_preparsed_data_from_file(char* filename)

if (FirstByteOfLinkCollectionArray != 0 && NumberLinkCollectionNodes != 0) {
size_t size_of_preparsed_data = offsetof(hidp_preparsed_data, caps) + FirstByteOfLinkCollectionArray + (NumberLinkCollectionNodes * sizeof(hid_pp_link_collection_node));
if (size_of_preparsed_data > 1024 * 1024) {
fprintf(stderr, "Error: preparsed data size too large: %zu\n", size_of_preparsed_data);
fclose(file);
return NULL;
}
pp_data->FirstByteOfLinkCollectionArray = FirstByteOfLinkCollectionArray;
pp_data->NumberLinkCollectionNodes = NumberLinkCollectionNodes;
FirstByteOfLinkCollectionArray = 0;
Expand Down
Loading