Skip to content

Extra menu layer removal for Import Content#19030

Open
zoltanvb wants to merge 1 commit into
libretro:masterfrom
zoltanvb:remove_extra_scan_menu_layer
Open

Extra menu layer removal for Import Content#19030
zoltanvb wants to merge 1 commit into
libretro:masterfrom
zoltanvb:remove_extra_scan_menu_layer

Conversation

@zoltanvb
Copy link
Copy Markdown
Contributor

Description

The Import Content menu now directly holds the scan options. Some extra logic was needed to avoid troubles when this menu is opened directly from Ozone main menu / XMB horizontal menu - in practice, this means that left/right does not change menu item values when in Ozone main menu, and horizontal scrolling only works for the first and last menu entry when this item is in its own horizontal tab for XMB.

This was one of the postponed issues in the original PR #18641. In some menu structures, "Scan Directory" / "Scan File" still remained, that is now also removed. Tested with all menu drivers * content scan in main menu / submenu combinations, should work as expected.

Related Pull Requests

#18641

@sonninnos
Copy link
Copy Markdown
Collaborator

Please don't add MENU_ST_FLAG_PRETEND_CORE_INIT back since it is not used anymore.

@LibretroAdmin
Copy link
Copy Markdown
Contributor

I'd still like to add back 'Scan File' , 'Scan Directory' though to that menu

@zoltanvb
Copy link
Copy Markdown
Contributor Author

Erroneous flag reverted now (it was coming in through the rebase).

Not sure if Scan File / Scan Directory would improve the situation. The default operation is now Fully Automatic, which means going to Content Scan, selecting a location, and doing Start Scan achieves the same result as earlier Scan Directory. This is just marginally worse than Scan Directory, which did this without a second action, immediately on selecting the entry.

Now thinking of this... maybe the operation could be changed that in the fully automatic mode, there is no need to go back and do "Start Scan", but selection would immediately trigger the scan. Combined with the last postponed change from the original PR (allowing selection of file/directory without separate option), probably this would be the most streamlined way. Would this be acceptable? Not in this PR, though, I think this is useful on its own.

@zoltanvb zoltanvb force-pushed the remove_extra_scan_menu_layer branch from 345fb81 to a526aba Compare May 25, 2026 17:57
The Import Content menu now directly holds the scan options. Some
extra logic was needed to avoid troubles when this menu is opened
directly from Ozone main menu / XMB horizontal menu.
@zoltanvb zoltanvb force-pushed the remove_extra_scan_menu_layer branch from a526aba to ca31785 Compare May 25, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants