Add no-js fallback #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@timiwahalahti need help with this? codesniffer just doesn't like your tabs. :) |
Member
|
@timiwahalahti got any time to fix this? Could be an useful feature for 1.5 😉 phpcbf should fix any tabs for you: |
Member
Author
|
I'll milestone this to 1.5 and fix this week. |
Member
Author
|
I'll work with this next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try this PR again with different branch.
As discussed in #50, this implements quite simple fallback to handler when submitting form without javascript. It can be turned on with filter.
Because some terms are reserved for WordPress core, this PR also implements check for those in fallback mode and shows error when using those terms as input names.
After successful form handling user is redirected to referrer page and thank you message is shown instead of form. When validation contains errors, message from validator is shown below form the same way as with javascript. Only downside is that inputs are cleared :/ But I think we can accept that, because browsers supports input checks quite widely. Can we?
Needs a bit more testing, updates to README and opinion about success/error handling.