Get all CPAN distributions using scroll API for MetaCPAN#2817
Open
zmughal wants to merge 2 commits intolibrariesio:mainfrom
Open
Get all CPAN distributions using scroll API for MetaCPAN#2817zmughal wants to merge 2 commits intolibrariesio:mainfrom
zmughal wants to merge 2 commits intolibrariesio:mainfrom
Conversation
Author
|
I think I could shorten the code a little bit by using a ternary operator inside the loop. Let me know which approach you prefer! |
Author
This uses the ElasticSearch scroll API to get all CPAN distributions <https://www.elastic.co/guide/en/elasticsearch/reference/2.4/search-request-scroll.html>. Fixes <librariesio#1961>.
This reverts commit 9c6d0f9. Connects with <librariesio#1961>.
106cda7 to
aece71c
Compare
Author
|
Fixed the merge conflict. |
Author
|
Hello! What can I do to get this merged or, if needed, implement similar functionality in another repository? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1961.
which is roughly what we get from
Of note, searching for distributions directly gets:
I'm not yet sure about why there is a discrepancy.