refactor(uds): Move WASM feature flagging to root Cargo.toml#3503
Merged
Conversation
Crates that don't compile for WASM are feature flagged in the root `Cargo.toml`, expcept for `libp2p-uds`. This commit removes the inconsistency. As a side-effect, this might help prevent bugs like libp2p#3502 going forward.
thomaseizinger
approved these changes
Feb 24, 2023
Contributor
|
This pull request has merge conflicts. Could you please resolve them @mxinden? 🙏 |
Contributor
|
Needs new feature gates on the module declaration. |
Member
Author
Thanks @thomaseizinger. That saved me a bit of debugging! |
…ds-longterm-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Crates that don't compile for WASM are feature flagged in the root
Cargo.toml, expcept forlibp2p-uds. This commit removes the inconsistency.As a side-effect, this might help prevent bugs like #3502 going forward.
Notes
Links to any relevant issues
Open Questions
Change checklist