Skip to content

Adjust lightScope label handling #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9il merged 1 commit into from
Jan 18, 2026
Merged

Adjust lightScope label handling #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion source/mir/ndslice/slice.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ public:
/// ditto
auto lightScope()() return scope immutable @property
{
auto ret = Slice!(LightImmutableOf!(LightScopeOf!Iterator), N, kind, staticMap!(LightImmutableOfLightConstOf(Labels)))
auto ret = Slice!(LightImmutableOf!(LightScopeOf!Iterator), N, kind, staticMap!(LightImmutableOfLightConstOf, Labels))
(_structure, .lightScope(_iterator));
foreach(i; Iota!L)
ret._labels[i] = .lightScope(_labels[i]);
Expand Down Expand Up @@ -4156,3 +4156,21 @@ unittest
row[3] = 6;
assert(matrix[2, 3] == 6); // D & C index order
}

// Test fix to issue #470
@safe pure nothrow @nogc
version(mir_ndslice_test)
unittest
{
import mir.ndslice.slice: LightImmutableOfLightConstOf, Slice, Contiguous;
import std.meta: staticMap;
// Make `x` immutable with label to ensure trigger of staticMap with immutable lightScope overload
alias T = Slice!(int*, 2, Contiguous, int*);
immutable T x = T.init;
// For compilation of immutable lightScope overload with auto return type inference
alias R = typeof(x.lightScope);
// Ensure `R` is a Slice
static assert(is(T : Slice!(Iterator, 2, Contiguous), Iterator));
// Ensure staticMap working properly
static assert(is(R.Labels[0] == staticMap!(LightImmutableOfLightConstOf, int*)[0]));
}
Loading