💥 Change block state semantics & remove sync_wait #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR Resolves #16 "Add `blocked_by::external` to support future coro compatibility." We implement this state by redefining its semantics. The blocking states previously had the semantic that all states are poll-able except for time and external. Now, `blocked_by::external` is poll-able. The semantics for external is that a coroutines that invoke a third party coroutine must supervise that coroutine. They are now supervisors meaning that they stay as the active coroutine for their context (proxy or otherwise). This summoned a new question about the viability of sync_wait. If time blocking is not poll-able then sync wait cannot be used as it does not have a means to schedule the coroutine some duration into the future. This change introduces basic_context which provides its own sync_wait function that takes a callable that delays execution until the requested time delay has elapsed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR Resolves #16 "Add
blocked_by::externalto support future coro compatibility." We implement this state by redefining its semantics. The blocking states previously had the semantic that all states are poll-able except for time and external. Now,blocked_by::externalis poll-able. The semantics for external is that a coroutines that invoke a third party coroutine must supervise that coroutine. They are now supervisors meaning that they stay as the active coroutine for their context (proxy or otherwise).This summoned a new question about the viability of sync_wait. If time blocking is not poll-able then sync wait cannot be used as it does not have a means to schedule the coroutine some duration into the future.
This change introduces basic_context which provides its own sync_wait function that takes a callable that delays execution until the requested time delay has elapsed.