Make warnings-as-errors configurable and fix pedantic semicolon warning#1308
Open
Akshayembate wants to merge 1 commit into
Open
Make warnings-as-errors configurable and fix pedantic semicolon warning#1308Akshayembate wants to merge 1 commit into
Akshayembate wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
-Werrorconfigurable through a new CMake option:CPR_WARNINGS_AS_ERRORSDefault behavior remains unchanged (
ON).Motivation
Some downstream projects and newer compiler versions may emit pedantic warnings that should not always fail the build. This change allows users to disable
-Werrorwhile still keeping warning flags enabled.Changes
CPR_WARNINGS_AS_ERRORSoption-Werrorasync.cpp