run-vmtest: sched_ext selftests support #149
Conversation
theihor
force-pushed
the
run-scx
branch
2 times, most recently
from
be26ac2 to
a68f941
Compare
Signed-off-by: Ihor Solodrai <ihor.solodrai@pm.me>
Signed-off-by: Ihor Solodrai <ihor.solodrai@pm.me>
| # HACK: We need to unmount /tmp to access /tmp from the container.... | ||
| vmtest -k "${VMLINUZ}" --kargs "panic=-1 sysctl.vm.panic_on_oom=1" "umount /tmp && \ |
There was a problem hiding this comment.
I was surprised to see this.... but we essentially do not need to umount /tmp since danobi/vmtest@0a63dce
There was a problem hiding this comment.
Yeah. I actually had to remove it, otherwise it failed to umount.
chantra
left a comment
chantra
left a comment
There was a problem hiding this comment.
LGTM. I wonder if another diff on top would be worthwhile to uniformize how we discover which VMTEST_SCRIPT to use.
| - {"name": "gcc", "fullname": "gcc", "version": 17} | ||
| - {"name": "llvm", "fullname": "llvm-17", "version": 17} | ||
| tests: [{"include": [{"test": "test_progs", "continue_on_error": false, "timeout_minutes": 360}, {"test": "test_progs_no_alu32", "continue_on_error": false, "timeout_minutes": 360}, {"test": "test_verifier", "continue_on_error": false, "timeout_minutes": 360}, {"test": "test_maps", "continue_on_error": false, "timeout_minutes": 360}]}] | ||
| tests: |
| trap 'exit 2' ERR | ||
|
|
||
| source $(cd $(dirname $0) && pwd)/../helpers.sh | ||
| source "${GITHUB_ACTION_PATH}/../helpers.sh" |
There was a problem hiding this comment.
why the change from $(cd $(dirname $0) && pwd) to ${GITHUB_ACTION_PATH}?
There was a problem hiding this comment.
I've been trying to use common env vars for paths everywhere, and $GITHUB_ACTION_PATH makes most sense for actions, when you're looking for relative paths.
However, in this case I don't think important, so I don't mind leaving pwd.
Any particular reasons in favor of $(cd $(dirname $0) && pwd)?
Thanks. There are more changes to it in #150, and follow ups are very likely. Initially I thought to pass VMTEST_SCRIPT as an action input, and then changed my mind (don't remember why). Maybe we'll do that eventually. |
Signed-off-by: Ihor Solodrai <ihor.solodrai@pm.me>
Signed-off-by: Ihor Solodrai <ihor.solodrai@pm.me>
2 participants
No description provided.