Skip to content

Fix xcode size_t variant issue, delint. #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 2 commits into from
May 16, 2026
Merged

Fix xcode size_t variant issue, delint. #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff60cec
Remove dead code.
evoskuil May 16, 2026
a16381a
Fix xcode size_t variant issue.
evoskuil May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/protocols/electrum/electrum_setup_fixture.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,12 @@ struct electrum_setup_fixture
boost::json::value receive();
int64_t get_error(const std::string& request);
boost::json::value get(const std::string& request);
void notify(node::chase event_, node::event_value value={});
bool handshake(electrum::version version,
const std::string& name="test", network::rpc::code_t id={});

// 0_32 vs {} for xcode variant issue.
void notify(node::chase event_, node::event_value value=0_32);

protected:
configuration config_;
test::store_t store_;
Expand Down
3 changes: 0 additions & 3 deletions test/protocols/native/native_block.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,6 @@ BOOST_AUTO_TEST_CASE(native__ws_top_subscribe__progressive_notify__expected)
BOOST_REQUIRE(query_.set(test::bogus_block10, database::context{ 0, 10, 0 }, false, false));
BOOST_REQUIRE(query_.set(test::bogus_block11, database::context{ 0, 11, 0 }, false, false));
BOOST_REQUIRE(query_.set(test::bogus_block12, database::context{ 0, 12, 0 }, false, false));
const auto hash10 = test::bogus_block10.transactions_ptr()->at(1)->hash(false);
const auto hash11 = test::bogus_block11.transactions_ptr()->at(0)->hash(false);
const auto hash12 = test::bogus_block12.transactions_ptr()->at(0)->hash(false);

const auto response = ws_get_json("/v1/top/subscribe?format=json");
BOOST_REQUIRE(response.is_int64());
Expand Down
3 changes: 2 additions & 1 deletion test/protocols/native/native_setup_fixture.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ struct native_setup_fixture
boost::json::value ws_get_json(std::string_view message);
system::data_chunk ws_get_data(std::string_view message);

void notify(node::chase event_, node::event_value value={});
// 0_32 vs {} for xcode variant issue.
void notify(node::chase event_, node::event_value value=0_32);

protected:
server::configuration config_;
Expand Down
Loading