Skip to content

Update block setter to provide height (db change). #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 2 commits into from
Feb 12, 2026
Merged

Update block setter to provide height (db change). #967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6aec57
Comment typo.
evoskuil Feb 12, 2026
07e806c
Update block setter to provide height (db change).
evoskuil Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/chasers/chaser_validate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ void chaser_validate::complete_block(const code& ec, const header_link& link,

// VALID BLOCK
// Under deferral there is no state change, but downloads will stall unless
// he window is closed out, so notify the check chaser of the increment.
// the window is closed out, so notify the check chaser of the increment.
notify(ec, chase::valid, possible_wide_cast<height_t>(height));

if (!defer_)
Expand Down
2 changes: 1 addition & 1 deletion src/protocols/protocol_block_in_31800.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ bool protocol_block_in_31800::handle_receive_block(const code& ec,
// Commit block.txs.
// ........................................................................

if (const auto code = query.set_code(*block, link, checked, bypass))
if (const auto code = query.set_code(*block, link, checked, bypass, height))
{
LOGF("Failure storing block [" << encode_hash(hash) << ":" << height
<< "] from [" << opposite() << "] " << code.message());
Expand Down
Loading