Skip to content

Fix changes meaning g++ error for rpc::value_type. #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 2 commits into from
Dec 18, 2025
Merged

Fix changes meaning g++ error for rpc::value_type. #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cf903d
Fix changes meaning g++ error for rpc::value_type.
evoskuil Dec 18, 2025
e470eff
Remove dead code.
evoskuil Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/bitcoin/network/messages/json/body.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ struct json_value
/// Because of the parser and serializer members, neither the reader nor writer
/// is movable and as such must be in-place contructed (e.g. variant contruct).
template <typename Value = json_value>
struct BCT_API body
struct body
{
using value_type = Value;

Expand Down
6 changes: 3 additions & 3 deletions include/bitcoin/network/messages/rpc/body.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ namespace network {
namespace rpc {

template <typename Type>
struct value_type
struct message_type
: public json::json_value
{
Type message{};
Expand All @@ -38,9 +38,9 @@ struct value_type
/// Extends json::body with JSON-RPC validation.
template <typename Message>
struct BCT_API body
: public json::body<value_type<Message>>
: public json::body<message_type<Message>>
{
using message_value = value_type<Message>;
using message_value = message_type<Message>;
using base = typename json::body<message_value>;
using value_type = base::value_type;

Expand Down
Loading